Geoip database management cache invalidation #16222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 Build Succeeded
|
|
@logstashmachine backport 8.14 |
3 tasks
yaauie
added a commit
that referenced
this pull request
Jun 18, 2024
andsel
pushed a commit
to andsel/logstash
that referenced
this pull request
Jul 12, 2024
* geoip: failing specs demonstrating elastic#16221 * geoip: invalidate cached db state when receiving updates/expiries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Resolves a regression from 8.12.0 in GeoIP Database Management in which a new instance of a Geoip Filter can be provided with a stale path for a database that no longer exists on disk, causing its pipeline to crash.
What does this PR do?
Updates the Geoip Filter's x-pack extension to properly invalidate its cached database path when receiving notifications of the database being updated or expired.
Why is it important/What is the impact to the user?
Prevents a situation where a pipeline containing a GeoIP filter cannot be reloaded until the process has been restarted.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Related issues