fix string interpolation cache api and related specs #4325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # clear the global compiled templates cache | ||
| def clear_cache | ||
| Java::ComLogstash::StringInterpolation.get_instance.clear_cache; |
There was a problem hiding this comment.
Style question - any reason you chose this syntax instead of com.logstash.StringInterpolation ?
There was a problem hiding this comment.
I believe this is the preferred way of referencing Java classes, the other notations AFAIU is only for top level Java packages java, javax, org, and com per https://github.com/jruby/jruby/wiki/CallingJavaFromJRuby#referencing-java-classes-using-full-qualified-class-name
|
I only have style concerns. LGTM. The style points I commented on can be resolved at a later date - I have no preference. Merging. :) |
colinsurprenant
added a commit
that referenced
this pull request
Dec 10, 2015
|
perfect, thanks! |
colinsurprenant
added a commit
to colinsurprenant/logstash
that referenced
this pull request
Dec 10, 2015
colinsurprenant
added a commit
to colinsurprenant/logstash
that referenced
this pull request
Dec 10, 2015
|
this also need to be merged into 2.x, will do |
colinsurprenant
added a commit
that referenced
this pull request
Dec 10, 2015
colinsurprenant
added a commit
that referenced
this pull request
Dec 10, 2015
colinsurprenant
added a commit
to colinsurprenant/logstash
that referenced
this pull request
Jan 12, 2016
colinsurprenant
added a commit
to colinsurprenant/logstash
that referenced
this pull request
Jan 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cache_sizeandclear_cachemethods to StringInterpolationFixes #4249 and relates to #4191 and #4229