Make JAVA_OPTS and LS_JAVA_OPTS work consistently on Windows #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by making it consistent with the way in which they are handled in Linux
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
|
@todd-bowles-onthehouse thanks for this patch. can you please perform step 2 of https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md#contribution-steps |
|
Rats, I thought I did. Onthehouse has a contributor agreement with Elastic to my knowledge, and I was recently added to it. Is there any way that I can track down the mismatch? |
|
@todd-bowles-onthehouse confirmed CLA. Thanks |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 11, 2016
…by making it consistent with the way in which they are handled in Linux Fixes #4758
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 11, 2016
…by making it consistent with the way in which they are handled in Linux Fixes #4758
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 11, 2016
…by making it consistent with the way in which they are handled in Linux Fixes #4758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Logstash on Windows, there is no way to override its default Java options.
In my case specifically, I needed a way to turn off the constant generation of memory dump files, because they were filling up disks on production machines and it was getting increasingly annoying.