fix warning message when set USE_DRIP=1 and no JAVA_OPTS set in system #6034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind doing step 2 of the contributing guide? https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md#contribution-steps |
|
CLA signed |
|
LGTM |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Oct 14, 2016
jordansissel
pushed a commit
that referenced
this pull request
Oct 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching logstash with option
USE_DRIP=1likein function
setup_drip, it would set$JAVA_OPTS; then in follwing functionsetup_java, it would output warning message that default $JAVA_OPTS would be overwritten. But actually user did not set "default $JAVA_OPTS".This fix would not output such warning message if user did not set $JAVA_OPTS