[ML] Upgrade to PyTorch 2.3.1 #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Docker images and dependecy files with PyTorch 2.3.1. Testing on Linux x86_64 gives promising indications that this version of PyTorch may resolve some memory allocation issues related to the `pytorch_inference` process. Opening this PR to better test it across the range of platforms and architectures that we support.
edsavage
added
>build
:ml
dependencies
|
Compilation errors for the macOS intel cross compilation build are due to a (now) too old compiler version and for the macOS aarch64 build there's a problem with |
valeriy42
approved these changes
Jul 12, 2024
|
|
||
| (cd ${REPO_ROOT} && ./gradlew --info -Dbuild.version_qualifier=${VERSION_QUALIFIER:-} -Dbuild.snapshot=$BUILD_SNAPSHOT -Dbuild.ml_debug=$ML_DEBUG $TASKS) || TEST_OUTCOME=$? | ||
| (cd ${REPO_ROOT} && ./gradlew --info -Dbuild.version_qualifier=${VERSION_QUALIFIER:-} -Dbuild.snapshot=$BUILD_SNAPSHOT -Dbuild.ml_debug=$ML_DEBUG $TASKS) || TEST_OUTCOME=$? | ||
| else |
There was a problem hiding this comment.
Is this the branch for testing Windows? If so, maybe you can add a comment so we can find our way around this file more easily in the future.
Co-authored-by: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Aug 14, 2024
Update Docker images and dependency files with PyTorch 2.3.1. Testing on Linux x86_64 gives promising indications that this version of PyTorch may resolve some memory allocation issues related to the `pytorch_inference` process. Co-authored-by: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Aug 14, 2024
…#2705) Release notes need updating following backport of PyTorch 2.3.1 changes to 8.15.1
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Aug 14, 2024
…#2705) Release notes need updating following backport of PyTorch 2.3.1 changes to 8.15.1
edsavage
added a commit
that referenced
this pull request
Aug 18, 2024
Update Docker images and dependency files with PyTorch 2.3.1. Testing on Linux x86_64 gives promising indications that this version of PyTorch may resolve some memory allocation issues related to the `pytorch_inference` process. Co-authored-by: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com> Backports #2688
edsavage
added a commit
that referenced
this pull request
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Docker images and dependency files with PyTorch 2.3.1.
Testing on Linux x86_64 gives promising indications that this version of
PyTorch may resolve some memory allocation issues related to the
pytorch_inferenceprocess.Opening this PR to better test it across the range of platforms and
architectures that we support.