[ML] Make the ML native code more ".app"-like on macOS #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality may be required for notarization on macOS Catalina.
droberts195
commented
Aug 14, 2019
There was a problem hiding this comment.
The values can be extracted from a program built after this change as follows:
bash-3.2$ launchctl plist __TEXT,__info_plist .objs/autodetect
{
"CFBundleIdentifier" = "co.elastic.ml-cpp.autodetect";
"CFBundleDevelopmentRegion" = "English";
"CFBundleDisplayName" = "autodetect";
"CFBundleName" = "autodetect";
"CFBundleVersion" = "8.0.0";
"CFBundleInfoDictionaryVersion" = "6.0";
};
mk/make_info_plist.sh
Outdated
| <key>CFBundleDevelopmentRegion</key> | ||
| <string>English</string> | ||
| <key>CFBundleIdentifier</key> | ||
| <string>co.elastic.ml-cpp.$ML_TARGET</string> |
There was a problem hiding this comment.
Exactly what to use here beyond co.elastic is not decided. I've used the repo name followed by the program name as a start.
| <key>CFBundleDisplayName</key> | ||
| <string>$ML_TARGET</string> | ||
| <key>CFBundleVersion</key> | ||
| <string>$ML_VERSION_NUM</string> |
There was a problem hiding this comment.
This deliberately excludes qualifiers like beta1 or SNAPSHOT - the field only tolerates digits and periods.
Static analysis files are now named *.xml (after all .plist files really are .xml files)
Also make sure the identifier only uses valid characters
droberts195
changed the title
edsavage
approved these changes
Sep 20, 2019
set_env.sh
Outdated
| @@ -36,7 +36,7 @@ case `uname` in | |||
| if [ -z "$CPP_CROSS_COMPILE" ] ; then | |||
| BUNDLE_PLATFORM=linux-x86_64 | |||
| else | |||
| if [ "$CPP_CROSS_COMPILE" = macosx ] ; then | |||
| if [ "$CPP_CROSS_COMPILE" = macos ] ; then | |||
There was a problem hiding this comment.
This will also require a change to CPP_CROSS_COMPILE in dev-tools//docker/macosx_builder/Dockerfile
There was a problem hiding this comment.
There are actually quite a few places I'll have to change to switch CPP_CROSS_COMPILE from using macosx to macos, and it will introduce an annoying discrepancy between branches in the Jenkins infrastructure. So I think I'll revert this one place in this PR. Maybe a future PR can do the rename fully.
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Sep 24, 2019
This is the Java side of elastic/ml-cpp#593 with a fallback so that ml-cpp bundles with either the new or old directory structure work for the time being. A few days after merging the C++ changes a followup to this change will be made that removes the fallback.
When this PR started out we thought we'd be shipping a number of standalone "command line tools". But that didn't work with notarization, so we had to make a more radical change, to become an app. (I also removed some dead code related to detecting Linux MUSL.)
|
I think this is ready now, but this PR must not be merged until a few days after elastic/elasticsearch#47013 |
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Sep 25, 2019
This is the Java side of elastic/ml-cpp#593 with a fallback so that ml-cpp bundles with either the new or old directory structure work for the time being. A few days after merging the C++ changes a followup to this change will be made that removes the fallback.
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Sep 25, 2019
This change removes the temporary controller location fallback introduced in elastic#47013. Relates elastic/ml-cpp#593
|
elastic/elasticsearch#47104 needs to be merged a few days after this |
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Sep 27, 2019
This is the Java side of elastic/ml-cpp#593 with a fallback so that ml-cpp bundles with either the new or old directory structure work for the time being. A few days after merging the C++ changes a followup to this change will be made that removes the fallback.
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Sep 30, 2019
Successful notarization and acceptance by Gatekeeper on macOS Catalina requires that the ML programs and dynamic libraries be arranged into the directory structure used by macOS apps. Backport of elastic#593
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Sep 30, 2019
Fixes a bug introduced in elastic#593
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Sep 30, 2019
Fixes a bug introduced in elastic#593
droberts195
added a commit
that referenced
this pull request
Sep 30, 2019
Fixes a bug introduced in #593
droberts195
added a commit
that referenced
this pull request
Sep 30, 2019
Successful notarization and acceptance by Gatekeeper on macOS Catalina requires that the ML programs and dynamic libraries be arranged into the directory structure used by macOS apps. Backport of #593
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Sep 30, 2019
Successful notarization and acceptance by Gatekeeper on macOS Catalina requires that the ML programs and dynamic libraries be arranged into the directory structure used by macOS apps. Backport of elastic#593
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Oct 1, 2019
This is the Java side of elastic/ml-cpp#593 with a fallback so that ml-cpp bundles with either the new or old directory structure work for the time being. A few days after merging the C++ changes a followup to this change will be made that removes the fallback.
droberts195
added a commit
that referenced
this pull request
Oct 1, 2019
Successful notarization and acceptance by Gatekeeper on macOS Catalina requires that the ML programs and dynamic libraries be arranged into the directory structure used by macOS apps. Backport of #593
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Oct 4, 2019
This change removes the temporary controller location fallback introduced in #47013. Relates elastic/ml-cpp#593
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Oct 4, 2019
This change removes the temporary controller location fallback introduced in #47013. Relates elastic/ml-cpp#593
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Oct 4, 2019
This change removes the temporary controller location fallback introduced in #47013. Relates elastic/ml-cpp#593
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Nov 1, 2019
This is the Java side of elastic/ml-cpp#593 with a fallback so that ml-cpp bundles with either the new or old directory structure work for the time being. A few days after merging the C++ changes a followup to this change will be made that removes the fallback.
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Nov 1, 2019
Successful notarization and acceptance by Gatekeeper on macOS Catalina requires that the ML programs and dynamic libraries be arranged into the directory structure used by macOS apps. Backport of elastic#593
droberts195
added a commit
that referenced
this pull request
Nov 1, 2019
Successful notarization and acceptance by Gatekeeper on macOS Catalina requires that the ML programs and dynamic libraries be arranged into the directory structure used by macOS apps. Backport of #593
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Nov 1, 2019
This change removes the temporary controller location fallback introduced in #47013. Relates elastic/ml-cpp#593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful notarization and acceptance by Gatekeeper on macOS
Catalina requires that the ML programs and dynamic libraries be
arranged into the directory structure used by macOS apps.