[ML] Upgrade to clang 6.0/Apple clang 10.1 for macOS compilation #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will build the macOS version 8.x of the ML C++ using Apple clang 10.1 on High Sierra or cross-compiling using clang 6.0 on Ubuntu 18.04. This will eventually facilitate use of C++17 (after separate PRs to upgrade the Windows and Linux compilers have also been merged).
Our code no longer triggers these annoying warnings, so there's no need to suppress them.
edsavage
approved these changes
Dec 3, 2019
| rm /tmp/trusted.gpg~ && \ | ||
| apt-add-repository "deb http://apt.llvm.org/xenial/ llvm-toolchain-xenial main" && \ | ||
| apt-get install --no-install-recommends -y clang-3.9 libclang1-3.9 libllvm3.9 llvm-3.9 llvm-3.9-runtime | ||
| wget -O - http://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add - && \ |
There was a problem hiding this comment.
we used to have --quiet here. Do we want to retain it?
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Dec 10, 2019
This is no longer required after elastic#867
droberts195
added a commit
that referenced
this pull request
Dec 10, 2019
This is no longer required after #867
3 tasks
|
This has been superseded by #1429. Since we won't be releasing 8.0 for a while we might as well take an extra step forward. The newer clang version has a more complete C++17 implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will build the macOS version 8.x of the ML C++ using
Apple clang 10.1 on High Sierra or cross-compiling using
clang 6.0 on Ubuntu 18.04. This will eventually facilitate
use of C++17 (after separate PRs to upgrade the Windows and
Linux compilers have also been merged).
Relates #1015