-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action: bump apm-agent-go version #81
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wil not depend on the APM Agent Go pipeline But it will use the updatecli tool to search for new versions and update them
v1v
added
automation
Team:Automation
Label for the Observability productivity team
labels
Jan 30, 2023
axw
reviewed
Jan 31, 2023
Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
v1v
commented
Jan 31, 2023
reakaleek
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This will not depend on the APM Agent Go pipeline
But it will use the updatecli tool to search for new versions and update them
Why
As Jenkins was somehow centralised then it was certainly possible to create pipeline/downstreams connections, as we are transitioning to GH actions it makes sense to use a different paradigm when bumping versions.
A similar implementation was done for the
apm-agent-node
and itsopbeans-node
project in elastic/opbeans-node#179Test
I created a branch based on this one and downgraded the Agent version to 2.1.0:
bash: .ci/go-install-elastic-apm-go.sh: No such file or directory
is caused since it uses the main branch where to apply the changes, update-cli checkout the repo and then apply the changes.If I run
.ci/go-install-elastic-apm-go.sh v2.2.0
then it works, if no changes to be applliedor if changes to be applied
Further details
If you wonder what's the main reason for using the
update-cli
tool, Ivan provided further details in one of the comments: