Add support for aggregate_metric_double field type #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
This was referenced Apr 12, 2023
| `field 1: default_metric is required`, | ||
| `field 2.metrics.2: 2.metrics.2 must be one of the following: "min", "max", "sum", "value_count", "avg"`, | ||
| `field 3: Must not be present`, | ||
| `field 3: Must not be present`, |
There was a problem hiding this comment.
Shame we don't report the field name with this error, but I remember that wasn't trivial.
There was a problem hiding this comment.
Yep, I tried some things, but I didn't manage to do it. Maybe we can do it directly in the underlying library, we already have it forked in https://github.com/elastic/gojsonschema.
| type: | ||
| const: aggregate_metric_double | ||
| required: | ||
| - type |
There was a problem hiding this comment.
What does this add?
required:
- type
There was a problem hiding this comment.
It avoids the condition to match when the type is not defined, what happens with external fields. Like this one:
- name: "@timestamp"
external: ecs
| required: | ||
| - default_metric | ||
| properties: | ||
| default_metric: |
There was a problem hiding this comment.
type: string is not needed here?
There was a problem hiding this comment.
type: string is defined in the referenced definition.
test/packages/bad_aggregate_metric_double/data_stream/foo/fields/fields.yml
Outdated
Show resolved
Hide resolved
jsoriano
added a commit
to elastic/kibana
that referenced
this pull request
Apr 17, 2023
## Summary Add support for fields of type `aggregate_metric_double` in EPM. Change in package spec introduced in elastic/package-spec#500. Fixes #154867 Closes elastic/package-spec#457 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios. ### How to test * Modify a package to include a field with type `aggregate_metric_double`, for example like this: ``` - name: some_metric type: aggregate_metric_double metrics: [ "min", "max", "sum", "value_count" ] default_metric: "max" ``` * Install elastic package with this branch of the package-spec included: elastic/package-spec#500, for this, from an elastic-package working directory: * `go mod edit -replace github.com/elastic/package-spec/v2=github.com/elastic/package-spec@main` * `go mod tidy` * `make install` * Build the package with `elastic-package build -v`. * Install the package with `elastic-package install -v`. * Check that the template contains the expected field. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
nikitaindik
pushed a commit
to nikitaindik/kibana
that referenced
this pull request
Apr 18, 2023
…ic#154920) ## Summary Add support for fields of type `aggregate_metric_double` in EPM. Change in package spec introduced in elastic/package-spec#500. Fixes elastic#154867 Closes elastic/package-spec#457 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios. ### How to test * Modify a package to include a field with type `aggregate_metric_double`, for example like this: ``` - name: some_metric type: aggregate_metric_double metrics: [ "min", "max", "sum", "value_count" ] default_metric: "max" ``` * Install elastic package with this branch of the package-spec included: elastic/package-spec#500, for this, from an elastic-package working directory: * `go mod edit -replace github.com/elastic/package-spec/v2=github.com/elastic/package-spec@main` * `go mod tidy` * `make install` * Build the package with `elastic-package build -v`. * Install the package with `elastic-package install -v`. * Check that the template contains the expected field. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
saarikabhasi
pushed a commit
to saarikabhasi/kibana
that referenced
this pull request
Apr 19, 2023
…ic#154920) ## Summary Add support for fields of type `aggregate_metric_double` in EPM. Change in package spec introduced in elastic/package-spec#500. Fixes elastic#154867 Closes elastic/package-spec#457 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios. ### How to test * Modify a package to include a field with type `aggregate_metric_double`, for example like this: ``` - name: some_metric type: aggregate_metric_double metrics: [ "min", "max", "sum", "value_count" ] default_metric: "max" ``` * Install elastic package with this branch of the package-spec included: elastic/package-spec#500, for this, from an elastic-package working directory: * `go mod edit -replace github.com/elastic/package-spec/v2=github.com/elastic/package-spec@main` * `go mod tidy` * `make install` * Build the package with `elastic-package build -v`. * Install the package with `elastic-package install -v`. * Check that the template contains the expected field. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds support for the
aggregate_metric_doublefield type.Why is it important?
This field type is used in TSDB use cases.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues