Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataset in compliance test #752

Merged
merged 1 commit into from
May 22, 2024

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented May 22, 2024

- is not allowed in datasets since elastic/kibana#182925

Fixes issue found in https://buildkite.com/elastic/package-spec/builds/664#018f9c74-ef57-4b56-b8ad-9b390d847bae:

Step a policy is created with "basic_input" package, "test" template, "test" input, "logfile" input type and dataset "spec.input-test": failed to create package policy: request failed with status 400, body: {"statusCode":400,"error":"Bad Request","message":"Package policy is invalid: inputs.logfile.streams.basic_input.test.vars.data_stream.dataset: Dataset contains invalid characters"}

We may consider adding validation for these fields in the test config files as a follow up.

@jsoriano jsoriano self-assigned this May 22, 2024
@jsoriano jsoriano requested a review from a team as a code owner May 22, 2024 12:20
@jsoriano jsoriano force-pushed the fix-compliance-test-data-stream branch from 6e8ce52 to 408f052 Compare May 22, 2024 12:24
@elasticmachine
Copy link

💚 Build Succeeded

cc @jsoriano

@jsoriano jsoriano merged commit db9a76d into elastic:main May 22, 2024
3 checks passed
@jsoriano jsoriano deleted the fix-compliance-test-data-stream branch May 22, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants