-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live search #79
Merged
Merged
Live search #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottybollinger
previously approved these changes
Feb 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of optional copy changes but LGTM otherwise!
Good points @scottybollinger. Mind re-reviewing? |
scottybollinger
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live Search
Finishes #74
react-search-ui
searchAsYouType
option toSearchBox
that will perform requests as input is entereddebounce
option toSearchBox
to let a user balance the number of requests made to the server vs. how responsive the SearchBox is.SearchBox
input value to be managed globally in thesearchTerm
state field, which lets theSearchBox
be cleared from outside (like via areset
action), and also sets us up for query suggestions.search-ui
refresh
anddebounce
option tosetSearchTerm
action which correspond to thesearchAsYouType
anddebounce
options on theSearchBox
.setSearchTerm
so that multiple calls tosetSearchTerm
can be made in quick succession. If a previous operation has actions locked,setSearchTerm
will disregard that and make the request anyway. Other actions will respect an "isLoading" flag that disallows another action to be made before the previous action has completed.