Build system #61
Build system #61
Conversation
|
@bleskes this is ready for a look |
| eslint: { | ||
| source: { | ||
| src: [ | ||
| 'public/**/*.js', |
There was a problem hiding this comment.
just wondering - no CSS/less linting?
There was a problem hiding this comment.
I've never used one, maybe worth exploring later
|
@spalger Thx. I'll fix the warnings once we get this in. I did run into an issue trying to use this - the result tar ball has the original index.js file, which refers to the test app. The code for that doesn't ship, so the Kibana installer complains about missing code references. |
|
we should probably also change the contriubting guide with instruction for the linting. |
|
@bleskes ready for another look |
| ]; | ||
|
|
||
| if (existsSync(resolve(__dirname, 'public/tests'))) { | ||
| apps.push({ |
There was a problem hiding this comment.
Gotta love em :) the new linting loves them too.
|
Commented on the wrong issue. Copied over here: it seems we fail to replace @SENSE_REVISION with the git sha |
|
can release not build but check that there is an existing binary for the right version? I always want to check the binary before uploading. However, if I run release it destroys the binary I just checked and now I'm unsure.. |
|
I'm sure there is a way to test for the existence of the build, but that is what the confirmation is for. If you select no then it will simply build (or you can just run |
|
Fixing the replacement of |
|
@spalger and I talked about it and we can let release rebake the tar ball for now. The reasoning is that now that we have a controlled latest url, we can safely upload broken s3 binaries without anyone downloading them by accident. |
|
LGTM |
Build and publish tasks for sense as a plugin.
build:
npm run build– clean, lint, copy, ziprelease:
npm run release– confirm, build, uploadThis also includes basic linting with eslint. The Airbnb rules are used as they are planned for use in Kibana (probably once 4.3 is released). These rules are very comprehensive so many exceptions were needed to make the build pass. In order to cut down on noise (5361 errors) most rules have been disabled. Only the
no-undefrule, which checks that a variable is defined before use, was left as a warning (28 warnings).