Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SHA-1 to SHA-256 hashing algorithm for authentication #14

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Change SHA-1 to SHA-256 hashing algorithm for authentication #14

merged 2 commits into from
Nov 22, 2021

Conversation

tutelaris
Copy link
Member

@tutelaris tutelaris commented Nov 22, 2021 •
edited
Loading

Description

Currently, the Site Search product supports both SHA-1 and SHA-256 generated token for authentication.
For security reasons, it's required to start using SHA-256 for new authentications.

This PR is dedicated to change SHA-1 to SHA-256 hashing algorithm

@tutelaris tutelaris self-assigned this Nov 22, 2021
JasonStoltz
JasonStoltz approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@JasonStoltz JasonStoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tutelaris tutelaris merged commit 06ddfdc into master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonStoltz JasonStoltz JasonStoltz approved these changes

@1stvamp 1stvamp Awaiting requested review from 1stvamp

@acrewdson acrewdson Awaiting requested review from acrewdson

@brianvans brianvans Awaiting requested review from brianvans

@valencitas valencitas Awaiting requested review from valencitas

Assignees

@tutelaris tutelaris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tutelaris @JasonStoltz