Remove leading ./ from zip entries
#682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The leading `.` on zip entry names is ignored by (at least) the Mac OS
`unzip` utility which means that every file appears to have an absolute
path, so unpacking a diagnostics bundle emits a warning for every entry:
warning: stripped absolute path spec from ...
There's no need to prefix every entry name with `./`, so this commit
removes the prefix to avoid these warnings.
andymjames
reviewed
Feb 20, 2024
There was a problem hiding this comment.
Hey X-School friend! I left for a while, but I'm back!
This looks pretty straight-forward, but since I never got too familiar with this particular project, I am going to get some extra eyes on here and guidance on how/if we test a PR like this.
I also feel like I need to make sure that nobody has some strong objection to the change (but I think you made a pretty good case for why this change would be good idea).
|
Hey @andymjames it's been a while, welcome back! No rush on this, it's just got to me enough times to chase down the problem :) |
pickypg
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leading
.on zip entry names is ignored by (at least) the Mac OSunziputility which means that every file appears to have an absolutepath, so unpacking a diagnostics bundle emits a warning for every entry:
There's no need to prefix every entry name with
./, so this commitremoves the prefix to avoid these warnings.