Add --ignore-https-errors flag #361
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
…s-1 into ignore-ssl-capability
|
I removed the promise rejection on stderr. We should generally be able to consider exit status for determining error. If we want to watch for |
|
@andrewvc Sure, Agree with your thoughts. We can watch out for exitCode which should generally work, but it was easier to debug when something was written on stderr either from CLI or errors thrown from Playwright which we haven't caught. But for now I would resolve and reject the promise if exitCode is != 0. |
|
@vigneshshanmugam if you're OK with the current behavior can I get an LGTM? |
| try { | ||
| return JSON.parse(data); | ||
| } catch (e) { | ||
| throw `Error ${e} could not parse data '${data}'`; |
Fixes #27202 NOTE: This requires a version of synthetics with elastic/synthetics#361 Adds an option to disable errors on invalid TLS certificates in heartbeat. Rather than try to work with ssl.verification_mode: none this adds a new option. The reason being that the behavior here is just too different to share a configuration option.
Fixes #27202 NOTE: This requires a version of synthetics with elastic/synthetics#361 Adds an option to disable errors on invalid TLS certificates in heartbeat. Rather than try to work with ssl.verification_mode: none this adds a new option. The reason being that the behavior here is just too different to share a configuration option. (cherry picked from commit 6c603a8)
Fixes #27202 NOTE: This requires a version of synthetics with elastic/synthetics#361 Adds an option to disable errors on invalid TLS certificates in heartbeat. Rather than try to work with ssl.verification_mode: none this adds a new option. The reason being that the behavior here is just too different to share a configuration option. (cherry picked from commit 6c603a8) Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
Adds the ability to ignore HTTPS errors via a flag. Checks one box in elastic/beats#27202
This is adding a flag, not a capability since if a user specifies the new option we want it to fail, rather than silently behave as though it were not set.