-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore https errors #27412
Ignore https errors #27412
Conversation
This reverts commit fea7eb6.
This reverts commit 3335780.
Fixes elastic#27202 Adds an option to disable errors on invalid TLS certificates in heartbeat. Rather than try to work with `ssl.verification_mode: none` this adds a new option. The reason being that the behavior here is just too different to share a configuration option.
Pinging @elastic/uptime (Team:Uptime) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 7.x |
Fixes #27202 NOTE: This requires a version of synthetics with elastic/synthetics#361 Adds an option to disable errors on invalid TLS certificates in heartbeat. Rather than try to work with ssl.verification_mode: none this adds a new option. The reason being that the behavior here is just too different to share a configuration option. (cherry picked from commit 6c603a8)
Command
|
Fixes #27202 NOTE: This requires a version of synthetics with elastic/synthetics#361 Adds an option to disable errors on invalid TLS certificates in heartbeat. Rather than try to work with ssl.verification_mode: none this adds a new option. The reason being that the behavior here is just too different to share a configuration option. (cherry picked from commit 6c603a8) Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
Fixes #27202
NOTE: This requires a version of synthetics with elastic/synthetics#361
Adds an option to disable errors on invalid TLS certificates in heartbeat.
Rather than try to work with
ssl.verification_mode: none
this adds a new option. The reason being that the behavior here is just too different to share a configuration option.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Badssl targets should function