Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore https errors #27412

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Ignore https errors #27412

merged 4 commits into from
Aug 17, 2021

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Aug 17, 2021

Fixes #27202

NOTE: This requires a version of synthetics with elastic/synthetics#361

Adds an option to disable errors on invalid TLS certificates in heartbeat.

Rather than try to work with ssl.verification_mode: none this adds a new option. The reason being that the behavior here is just too different to share a configuration option.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Badssl targets should function

- id: test
  name: A Test
  type: browser
  schedule: "@every 10s"
  ignore_https_errors: true
  source:
    inline:
      script: |-
       step('Go to home page', async () => {
         await page.goto('https://expired.badssl.com/');
       });  

Fixes elastic#27202

Adds an option to disable errors on invalid TLS certificates in
heartbeat.

Rather than try to work with `ssl.verification_mode: none` this adds a
new option. The reason being that the behavior here is just too
different to share a configuration option.
@andrewvc andrewvc added enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.15.0 labels Aug 17, 2021
@andrewvc andrewvc requested a review from a team as a code owner August 17, 2021 02:45
@andrewvc andrewvc self-assigned this Aug 17, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 17, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-17T02:45:45.921+0000

  • Duration: 66 min 45 sec

  • Commit: 647bd45

Test stats 🧪

Test Results
Failed 0
Passed 3389
Skipped 80
Total 3469

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 3389
Skipped 80
Total 3469

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc andrewvc merged commit 6c603a8 into elastic:master Aug 17, 2021
@andrewvc andrewvc deleted the ignore_https_errors branch August 17, 2021 16:03
@andrewvc
Copy link
Contributor Author

@Mergifyio backport 7.x

mergify bot pushed a commit that referenced this pull request Aug 17, 2021
Fixes #27202

NOTE: This requires a version of synthetics with elastic/synthetics#361

Adds an option to disable errors on invalid TLS certificates in heartbeat.

Rather than try to work with ssl.verification_mode: none this adds a new option. The reason being that the behavior here is just too different to share a configuration option.

(cherry picked from commit 6c603a8)
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2021

Command backport 7.x: success

Backports have been created

andrewvc added a commit that referenced this pull request Aug 17, 2021
Fixes #27202

NOTE: This requires a version of synthetics with elastic/synthetics#361

Adds an option to disable errors on invalid TLS certificates in heartbeat.

Rather than try to work with ssl.verification_mode: none this adds a new option. The reason being that the behavior here is just too different to share a configuration option.

(cherry picked from commit 6c603a8)

Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Heartbeat] ignore-https-errors should work for browsers
3 participants