Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable trace as part of rich-events #387

Merged
merged 1 commit into from Oct 7, 2021
Merged

feat: enable trace as part of rich-events #387

merged 1 commit into from Oct 7, 2021

Conversation

vigneshshanmugam
Copy link
Member

@apmmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-28T21:49:08.813+0000

  • Duration: 15 min 35 sec

  • Commit: 4e0359a

Test stats 🧪

Test Results
Failed 0
Passed 135
Skipped 0
Total 135

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

dominiqueclarke
dominiqueclarke reviewed Oct 6, 2021
View reviewed changes
__tests__/cli.test.ts
},
root_fields: expect.any(Object),
});
expect(screenshotRef).toBeDefined();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already test them in the json reporter, checking for existence is good enough for the CLI layer.

__tests__/cli.test.ts
.buffer()
.map(data => JSON.parse(data))
.find(({ type }) => type === 'step/metrics');
expect(traceData).toBeDefined();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any object specifics we can test against?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synthetics/__tests__/reporters/json.test.ts

Lines 132 to 163 in 2538c58

traces: [
{
name: 'navigationStart',
type: 'mark',
start: {
us: 3065705158085,
},
},
{
name: 'firstContentfulPaint',
type: 'mark',
start: {
us: 3065705560142,
},
},
{
name: 'layoutShift',
type: 'mark',
start: {
us: 463045197179,
},
score: 0.19932291666666668,
},
],
metrics: {
lcp: { us: 200 },
fcp: { us: 100 },
dcl: { us: 300 },
load: { us: 400 },
cls: 0.123,
},
});

dominiqueclarke
dominiqueclarke approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seeing metrics show up by default without passing capabilities flag.
Screen Shot 2021-10-07 at 4 04 08 PM

@vigneshshanmugam vigneshshanmugam merged commit 007a705 into elastic:master Oct 7, 2021
@vigneshshanmugam vigneshshanmugam deleted the enable-trace branch October 7, 2021 20:47
v1v added a commit to dominiqueclarke/synthetics that referenced this pull request Nov 22, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/360-kiban…
001fab1 
…a-fleet-heartbeat-synthetics-e2e-tests

* upstream/master:
  [jjbb] for scheduling e2e jobs (elastic#418)
  docs: release notes for beta.17 (elastic#415)
  1.0.0-beta.17
  feat: add --playwright-options (elastic#405)
  fix: ensure timestamps of events are inorder (elastic#413)
  fix: do not stash `.nvm` folder (elastic#414)
  deprecate suite-params option over params (elastic#406)
  fix: end timestamp should reflect duration (elastic#410)
  docs: release notes for 1.16.0 (elastic#403)
  1.0.0-beta.16
  fix: revert Playwright to 1.14.0 (elastic#402)
  docs: release notes for beta 15 (elastic#400)
  1.0.0-beta.15
  chore: update deps and fix lint issues (elastic#399)
  fix: handle page close during response event (elastic#398)
  chore: require node > 14 for usage (elastic#397)
  fix: fix megabytes to mbps (elastic#394)
  feat: enable trace as part of rich-events (elastic#387)
  feat: use events from PW for network data (elastic#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@shahzad31 shahzad31 Awaiting requested review from shahzad31

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable trace collection as part of rich events flag
3 participants
@vigneshshanmugam @apmmachine @dominiqueclarke