New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert Playwright to 1.14.0 #402
fix: revert Playwright to 1.14.0 #402
Conversation
vigneshshanmugam
commented
Oct 19, 2021
- fix Revert PW 1.15.0 update #401
- Effectively reverts the new changes and updates that makes capturing the network events from other tabs, popups easier. We will have to keep the older way which only captures the network events from current page.
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waterfall chart looks good, but I'm not seeing any step level data. Are step level metrics meant to be impacted by this?
@dominiqueclarke This change does not have anything to do with step metrics. How are you testing it and is step level metrics feature has to be enabled in the UI? I did a run with the synthetics CLI and i get all the trace events and metrics. |
@dominiqueclarke I just tested on 7.16.0:snapshot and can see the metrics without any issues - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…a-fleet-heartbeat-synthetics-e2e-tests * upstream/master: [jjbb] for scheduling e2e jobs (elastic#418) docs: release notes for beta.17 (elastic#415) 1.0.0-beta.17 feat: add --playwright-options (elastic#405) fix: ensure timestamps of events are inorder (elastic#413) fix: do not stash `.nvm` folder (elastic#414) deprecate suite-params option over params (elastic#406) fix: end timestamp should reflect duration (elastic#410) docs: release notes for 1.16.0 (elastic#403) 1.0.0-beta.16 fix: revert Playwright to 1.14.0 (elastic#402) docs: release notes for beta 15 (elastic#400) 1.0.0-beta.15 chore: update deps and fix lint issues (elastic#399) fix: handle page close during response event (elastic#398) chore: require node > 14 for usage (elastic#397) fix: fix megabytes to mbps (elastic#394) feat: enable trace as part of rich-events (elastic#387) feat: use events from PW for network data (elastic#372)