Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert Playwright to 1.14.0 #402

Merged
merged 1 commit into from Oct 19, 2021

Conversation

vigneshshanmugam
Copy link
Member

  • fix Revert PW 1.15.0 update #401
  • Effectively reverts the new changes and updates that makes capturing the network events from other tabs, popups easier. We will have to keep the older way which only captures the network events from current page.

@apmmachine
Copy link
Collaborator

❕ Build Aborted

Either there was a build timeout or someone aborted the build.'}

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-19T18:59:01.169+0000

  • Duration: 28 min 42 sec

  • Commit: 9c5bbfa

Test stats 🧪

Test Results
Failed 0
Passed 139
Skipped 0
Total 139

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waterfall chart looks good, but I'm not seeing any step level data. Are step level metrics meant to be impacted by this?

@vigneshshanmugam
Copy link
Member Author

@dominiqueclarke This change does not have anything to do with step metrics. How are you testing it and is step level metrics feature has to be enabled in the UI?

I did a run with the synthetics CLI and i get all the trace events and metrics.

@vigneshshanmugam
Copy link
Member Author

@dominiqueclarke I just tested on 7.16.0:snapshot and can see the metrics without any issues -
Screen Shot 2021-10-19 at 13 09 45

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshshanmugam vigneshshanmugam merged commit 0e2711a into elastic:master Oct 19, 2021
@vigneshshanmugam vigneshshanmugam deleted the revert-pw-update branch October 19, 2021 20:19
v1v added a commit to dominiqueclarke/synthetics that referenced this pull request Nov 22, 2021
…a-fleet-heartbeat-synthetics-e2e-tests

* upstream/master:
  [jjbb] for scheduling e2e jobs (elastic#418)
  docs: release notes for beta.17 (elastic#415)
  1.0.0-beta.17
  feat: add --playwright-options (elastic#405)
  fix: ensure timestamps of events are inorder (elastic#413)
  fix: do not stash `.nvm` folder (elastic#414)
  deprecate suite-params option over params (elastic#406)
  fix: end timestamp should reflect duration (elastic#410)
  docs: release notes for 1.16.0 (elastic#403)
  1.0.0-beta.16
  fix: revert Playwright to 1.14.0 (elastic#402)
  docs: release notes for beta 15 (elastic#400)
  1.0.0-beta.15
  chore: update deps and fix lint issues (elastic#399)
  fix: handle page close during response event (elastic#398)
  chore: require node > 14 for usage (elastic#397)
  fix: fix megabytes to mbps (elastic#394)
  feat: enable trace as part of rich-events (elastic#387)
  feat: use events from PW for network data (elastic#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert PW 1.15.0 update
3 participants