fix: fix megabytes to mbps #394

dominiqueclarke · 2021-10-07T19:09:25Z

Fixes #284

Fixes the default network throttling to Mbps

apmmachine · 2021-10-07T19:16:49Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-10-11T13:10:32.271+0000
Duration: 14 min 45 sec
Commit: d8912d4

Test stats 🧪

Test	Results
Failed	0
Passed	140
Skipped	0
Total	140

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

dominiqueclarke · 2021-10-07T19:22:49Z

src/helpers.ts

-export function megabytesToBytes(megabytes: number) {
-  return megabytes * 1024 * 1024;
+export function megabitsToBytes(megabytes: number) {
+  return megabytes * 125000;


@vigneshshanmugam is this the right calculation, or do we need the binary one?

1 MBps -> (1 * 1024 * 1024 / 8) bytes per second is the correct calculation

https://binary2hex.com/converting-megabits.html

dominiqueclarke · 2021-10-07T19:23:21Z

/test

vigneshshanmugam

The CLI options wording has to be renamed.

throttle network conditions for download throughput (d) in Mbps(Megabits/second), upload throughput (u) in Mpbs(Megabits/second)

vigneshshanmugam · 2021-10-07T20:42:47Z

src/helpers.ts

-  downloadThroughput: megabytesToBytes(5), // megabytes/second
-  uploadThroughput: megabytesToBytes(3), // megabytes/second
+  downloadThroughput: megabitsToBytes(5), // megabytes/second
+  uploadThroughput: megabitsToBytes(3), // megabytes/second
  latency: 20, // milliseconds,
  offline: false,
 }

 export function formatNetworkConditionsArgs(networkConditions: NetworkConditions) {


Please add comment that we need Devtools CDP expects format to be in bytes/second to make it clear.

vigneshshanmugam · 2021-10-07T20:45:37Z

src/helpers.ts

-export function megabytesToBytes(megabytes: number) {
-  return megabytes * 1024 * 1024;
+export function megabitsToBytes(megabytes: number) {
+  return megabytes * 125000;


1 MBps -> (1 * 1024 * 1024 / 8) bytes per second is the correct calculation

https://binary2hex.com/converting-megabits.html

vigneshshanmugam · 2021-10-07T20:45:49Z

src/helpers.ts

-export function bytesToMegabytes(bytes: number) {
-  return bytes / 1024 / 1024;
+export function bytesToMegabits(bytes: number) {
+  return bytes / 125000;


reverse of previous calc.

dominiqueclarke · 2021-10-07T22:15:11Z

/test

vigneshshanmugam

Still missing the changes in the parse args file.

synthetics/src/parse_args.ts

Lines 109 to 110 in 007a705

    
           new Option('--throttling <d/u/l>', 'List of options to throttle network conditions for download throughput (d) in megabytes/second, upload throughput (u) in megabytes/second and latency (l) in milliseconds.') 
        
             .default(DEFAULT_NETWORK_CONDITIONS_ARG)

Rest looks good.

dominiqueclarke · 2021-10-11T13:09:50Z

/test

vigneshshanmugam · 2021-10-11T15:07:43Z

src/helpers.ts

 }

 export const DEFAULT_NETWORK_CONDITIONS: NetworkConditions = {
-  downloadThroughput: megabytesToBytes(5), // megabytes/second
-  uploadThroughput: megabytesToBytes(3), // megabytes/second
+  downloadThroughput: megabitsToBytes(5), // Devtools CDP expects format to be in bytes/second 


@dominiqueclarke I forgot about this in last review, Does this config work with floating points? If not we need to truncate them.

CDP does not report any errors for floating points, and the tests pass as expected when passing with floating points. I did this manually, but happy to write an explicit test.

Don't think we need it, it was more of a question and what users would expect. We could round it off or leave it as it is, I will let you take the call.

I think it's fine. As far as user input, I think users will have a need to express mgbps as floating points for more precision. This will sometimes lead to floating points for the corresponding bytes value after applying the calculation. As long as CDP does not report an error, I think it's fine.

…a-fleet-heartbeat-synthetics-e2e-tests * upstream/master: [jjbb] for scheduling e2e jobs (elastic#418) docs: release notes for beta.17 (elastic#415) 1.0.0-beta.17 feat: add --playwright-options (elastic#405) fix: ensure timestamps of events are inorder (elastic#413) fix: do not stash `.nvm` folder (elastic#414) deprecate suite-params option over params (elastic#406) fix: end timestamp should reflect duration (elastic#410) docs: release notes for 1.16.0 (elastic#403) 1.0.0-beta.16 fix: revert Playwright to 1.14.0 (elastic#402) docs: release notes for beta 15 (elastic#400) 1.0.0-beta.15 chore: update deps and fix lint issues (elastic#399) fix: handle page close during response event (elastic#398) chore: require node > 14 for usage (elastic#397) fix: fix megabytes to mbps (elastic#394) feat: enable trace as part of rich-events (elastic#387) feat: use events from PW for network data (elastic#372)

dominiqueclarke force-pushed the fix/default-throttling branch 3 times, most recently from 7879317 to 4432d1c Compare October 7, 2021 19:14

dominiqueclarke commented Oct 7, 2021

View reviewed changes

dominiqueclarke requested a review from vigneshshanmugam October 7, 2021 19:32

dominiqueclarke force-pushed the fix/default-throttling branch from 4432d1c to dbecac2 Compare October 7, 2021 19:35

vigneshshanmugam requested changes Oct 7, 2021

View reviewed changes

fix megabytes to mbps

8dc6a6f

dominiqueclarke force-pushed the fix/default-throttling branch from dbecac2 to 8dc6a6f Compare October 7, 2021 22:09

vigneshshanmugam reviewed Oct 7, 2021

View reviewed changes

fix command line args

d8912d4

vigneshshanmugam approved these changes Oct 11, 2021

View reviewed changes

dominiqueclarke merged commit 565f487 into elastic:master Oct 11, 2021

dominiqueclarke deleted the fix/default-throttling branch October 11, 2021 23:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fix megabytes to mbps #394

fix: fix megabytes to mbps #394

dominiqueclarke commented Oct 7, 2021 •

edited

Loading

apmmachine commented Oct 7, 2021 •

edited

Loading

Build stats

Test stats 🧪

dominiqueclarke Oct 7, 2021

vigneshshanmugam Oct 7, 2021

dominiqueclarke commented Oct 7, 2021

vigneshshanmugam left a comment

vigneshshanmugam Oct 7, 2021 •

edited

Loading

vigneshshanmugam Oct 7, 2021

vigneshshanmugam Oct 7, 2021

dominiqueclarke commented Oct 7, 2021

vigneshshanmugam left a comment

dominiqueclarke commented Oct 11, 2021

vigneshshanmugam Oct 11, 2021

dominiqueclarke Oct 11, 2021

vigneshshanmugam Oct 11, 2021

dominiqueclarke Oct 11, 2021

	new Option('--throttling <d/u/l>', 'List of options to throttle network conditions for download throughput (d) in megabytes/second, upload throughput (u) in megabytes/second and latency (l) in milliseconds.')
	.default(DEFAULT_NETWORK_CONDITIONS_ARG)

fix: fix megabytes to mbps #394

fix: fix megabytes to mbps #394

Conversation

dominiqueclarke commented Oct 7, 2021 • edited Loading

apmmachine commented Oct 7, 2021 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dominiqueclarke commented Oct 7, 2021

vigneshshanmugam left a comment

Choose a reason for hiding this comment

vigneshshanmugam Oct 7, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dominiqueclarke commented Oct 7, 2021

vigneshshanmugam left a comment

Choose a reason for hiding this comment

dominiqueclarke commented Oct 11, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dominiqueclarke commented Oct 7, 2021 •

edited

Loading

apmmachine commented Oct 7, 2021 •

edited

Loading

vigneshshanmugam Oct 7, 2021 •

edited

Loading