fix: update hash logic to account for bundling #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
There is a risk with this approach, Making the hash based on the bundle would be problematic in few scenarios
- If any of the journey changes in a single file, then all journeys are affected
- Bundling code gets affected with esbuild library changes.
In any case, we need to fix this issue as its not the right behaviour, but lets think through other approaches and decide.
vigneshshanmugam
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
LGTM
We will proceed with this approach for now to fix the bug and work on a efficient way to bundle the journeys with the approach discussed here -#809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #802
update hash logic to account for bundling.
Earlier it was doing difference based on hash calculated before bundling, in updated logic diff will be done after hash calculated based on content of bundle.