Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align cli options between push and locations for url/auth #814

Merged
merged 9 commits into from
Aug 4, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 1, 2023

fixes #718
align cli options between push and locations for url/auth !!

image

src/cli.ts Outdated Show resolved Hide resolved
src/cli.ts Outdated Show resolved Hide resolved
src/cli.ts Outdated Show resolved Hide resolved
src/cli.ts Outdated Show resolved Hide resolved
src/locations/index.ts Show resolved Hide resolved
src/locations/index.ts Outdated Show resolved Hide resolved
src/cli.ts Outdated Show resolved Hide resolved
src/cli.ts Outdated Show resolved Hide resolved
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshshanmugam
Copy link
Member

Pushed one extra test for the locations with/without project settings.

@vigneshshanmugam vigneshshanmugam merged commit cd765d5 into main Aug 4, 2023
4 checks passed
@vigneshshanmugam vigneshshanmugam deleted the locations-url branch August 4, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make --url optional for locations command
2 participants