Updates for #138 #141
Merged
Updates for #138 #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 4, 2014 16:05
spalger
pushed a commit
that referenced
this pull request
Sep 8, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #138 added support for compression, this adds a global config setting that will suggest to elasticsearch that the client supports compression, as well a few more tests and a slightly simpler implementation using streams.
Support: Browsers do not support specifying the Accept-Encoding header. Doing so in Chrome logs a warning for each request.
Note: This will not work properly unless you enable compression in ES (see the
http.compressionsetting in es docs)