Fixes a bug that causes HTTPS to never be used. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pAgent version of KeepAliveAgent the connections always default to http instead of https, even when https is specified as the protocol.
|
Wow, good catch. Thanks for the patch, have you completed step 5 in CONTRIBUTING.md? |
|
Yea, just did. |
spalger
pushed a commit
that referenced
this pull request
Jan 14, 2014
Fixes a bug that causes HTTPS to never be used.
|
Thanks @jvonniedapn! |
cdituri
pushed a commit
to cdituri/elasticsearch-js
that referenced
this pull request
Jun 14, 2017
…03064944 Exec tachikoma update 20150803064944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that causes HTTPS to never be used. Without using the HttpsAgent version of KeepAliveAgent the connections always default to http instead of https, even when https is specified as the protocol.