Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor context to use golang's context #227

Open
AlmogBaku opened this issue Jun 27, 2017 · 2 comments
Open

Refactor context to use golang's context #227

AlmogBaku opened this issue Jun 27, 2017 · 2 comments

Comments

@AlmogBaku
Copy link
Contributor

The current proxycontext is limited(i.e. UserData is in use and we can't use it to attach extra data).

Refactoring the context to use the golang's context should solve a lot of issues(or potential issues) and to bring consistency with the community's context.

@elazarl
Copy link
Owner

elazarl commented Jun 27, 2017 via email

@AlmogBaku
Copy link
Contributor Author

  1. My objective is to put on the context the information about the user.
    Also, I suggest we'll move to the generic context package in order to allow compatibility with different packages.

The current implementation of UserData does not allow different packages to use this field because you need to put there a common struct that every package need to know how to put the information in.
Usage of context package solves that by having a common interface for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants