Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the number of caller, in android stock is in the notification title #18

Closed
grenryd opened this issue Nov 12, 2014 · 12 comments
Closed

the number of caller, in android stock is in the notification title #18

grenryd opened this issue Nov 12, 2014 · 12 comments
Assignees
Labels

Comments

@grenryd
Copy link

grenryd commented Nov 12, 2014

I'm using this addon to mirror the phones to xbmc.
I have a Samsung note 3 and everything works great but my girlfriend have a galaxy nexus and when someone is calling her it only displays:
"Incoming Call" and not the contact name as when someone calls my phone.

The problem is that add-on view only:

  • Android Application name => Kodi Notification title
  • Android Notification body => Kodi notification sub-title

the number of caller, in android stock is in the notification title

http://forum.kodi.tv/showthread.php?tid=204567&pid=1834637#pid1834637

@elbowz elbowz added the bug label Nov 12, 2014
@elbowz elbowz self-assigned this Nov 12, 2014
@elbowz
Copy link
Owner

elbowz commented Nov 13, 2014

thanks for issue reporting!

It's fixed in ea5c216

Wait for 0.8.14b release :)

@elbowz elbowz closed this as completed Nov 13, 2014
@grenryd
Copy link
Author

grenryd commented Nov 13, 2014

Great work Elbowz. Will give it a try as soon as I can.

@ruuk
Copy link
Collaborator

ruuk commented Nov 13, 2014

Waiting for 0.8.16b release, already had 0.8.14b :)

@elbowz
Copy link
Owner

elbowz commented Nov 13, 2014

I'm always the last man to know this things!! ;)

@ruuk: master say 0.8.12b (https://github.com/elbowz/xbmc.service.pushbullet/blob/master/addon.xml#L4)
what have you pushed on kody repository (develop branch?)

@ruuk
Copy link
Collaborator

ruuk commented Nov 13, 2014

I've been only pushing develop to my repository.
When we have stable versions, we merge develop into master, and push master into Kodi repository.
So master is always the last stable version, develop is basically testing/unstable.

@elbowz
Copy link
Owner

elbowz commented Nov 13, 2014

Ok understand:

  • your repo: develop
  • kody repo: master

Cool! I can publish this info on main thread, If anyone would like become a beta tester ;)

@grenryd: as ruuk say, you have to wait 0.8.16b (or you can download right now this: https://github.com/elbowz/xbmc.service.pushbullet/archive/develop.zip)

@ruuk
Copy link
Collaborator

ruuk commented Nov 13, 2014

Um... I don't think you merged into develop yet.

@elbowz
Copy link
Owner

elbowz commented Nov 13, 2014

I have made a push request...I'll waiting you

Do you want I change the version and changelog?

but how can I know if you have push develop on repo or not ? for the next merge I mean

@ruuk
Copy link
Collaborator

ruuk commented Nov 13, 2014

I'll post a update on the forum like I did with 0.8.14b. Perhaps I will make the posts more clear as to what sort of release it is.

You can change the version/changelog or I will. It'll be an hour or two before I can do the update.

@elbowz
Copy link
Owner

elbowz commented Nov 13, 2014

I have added something about it on main topic...but my english as is as.
If you want add/edit/correct, feel free!

I hope the final users will not be disoriented with a changelog referred to beta and not to stable...

ruuk referenced this issue Nov 13, 2014
Display the title of Android notification in mirroring mode (issue#18)
@ruuk
Copy link
Collaborator

ruuk commented Nov 13, 2014

The only thing I would change is Latest release to Latest stable release perhaps?

Also, your changelog and version change were fine, but I had to fix a small bug in the wild import removal 29465a1 - no big deal :)

@elbowz
Copy link
Owner

elbowz commented Nov 14, 2014

Thanks for your review!

rsajup added a commit to rsajup/elbowzv that referenced this issue Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants