Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async support #5

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add async support #5

wants to merge 11 commits into from

Conversation

andresv
Copy link

@andresv andresv commented Jan 24, 2024

No description provided.

@andresv andresv mentioned this pull request Jan 24, 2024
Closed
eldruin
eldruin reviewed Jan 25, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you!
Could you mention the async feature and support in the Readme and lib.rs?

CHANGELOG.md Outdated Show resolved Hide resolved
andresv and others added 2 commits January 25, 2024 10:09
@andresv @eldruin
Update CHANGELOG.md
d11b6a4 
Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@andresv
add docs about async driver
7af44a0
@andresv
Copy link
Author

andresv commented Jan 25, 2024

Added some docs about async feature.

eldruin
eldruin reviewed Jan 25, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
eldruin
eldruin reviewed Jan 25, 2024
View reviewed changes
src/lib.rs Show resolved Hide resolved
eldruin
eldruin reviewed Jan 25, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the minimum amount of embassy dependencies to make the example compile to the dev-dependencies?

@eldruin eldruin mentioned this pull request Jan 31, 2024
Closed
@nils-van-zuijlen nils-van-zuijlen mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresv @eldruin