Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipStream for subalbums #781

Closed
wants to merge 2 commits into from

Conversation

oxpa
Copy link

@oxpa oxpa commented May 14, 2018

Hello.

First of all, thank you for the gallery and subalbums. It's totally awesome!

There was a problem with my albums: they tend to occupy a lot of space (like 10+Gb). And were way to long to create. So I had to prepare zip files before the first client requests an archive.

With this patch no additional files are created, zip file is streamed right away (and due to low compression rate there is almost no overhead in terms of CPU).
I also had to change fnNotFound() slightly to make it easier to guess what's wrong. It looks to be useful anyway.

I understand that the patch doesn't meet guidelines. As soon as you like the idea itself - I will tidy up things.
I also used code from https://github.com/maennchen/ZipStream-PHP (MIT)
and https://github.com/php-fig/http-message (MIT)

@electerious
Copy link
Owner

This PR will be closed because I'm not actively working on Lychee anymore. The repository of Lychee will stay available, but the main development continues under the Lychee Organisation. A fork maintained by the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants