Skip dependency checks #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not fetch dependencies but ability to add requirements preserved Todd Pickell @tapickell <tapickell@gmail.com> Nola Stowe @rubygeek <nola@rubygeek.com>
Todd Pickell @tapickell <tapickell@gmail.com> Nola Stowe @rubygeek <nola@rubygeek.com>
This merges in some changes from this PR #15 Thank you to g3kk0 for creating that pr. This branch and the pr branch do essesntialy the same thing but look at it from differenct perspectives. As part of the requirements from GE the load dependencies option should be off by default now and only loading of the option is true. Todd Pickell @tapickell <tapickell@gmail.com>
Still have 6 tests failing locally related to VCR MySQL issue in inventory builder spec Todd Pickell @tapickell <tapickell@gmail.com>
This still needs a full deployment test before release of a version that contains this feature Todd Pickell @tapickell <tapickell@gmail.com>
Test this and it works as expected with --load-deps / --no-load-deps options. Todd Pickell @tapickell <tapickell@gmail.com>
Todd Pickell @tapickell <tapickell@gmail.com>
Todd Pickell @tapickell <tapickell@gmail.com>
| @@ -59,6 +59,13 @@ Once you are done modifying the `inventory.yml` file, you can run the `mirror` c | |||
|
|
|||
| $ minimart mirror | |||
|
|
|||
| By default this will not load the dependencies of the cookbooks in your | |||
| `inventory.yml` file if you require it to also grab all the dependencies | |||
There was a problem hiding this comment.
put a period after inventory.yml file. Capitalize if If you ...
Todd Pickell @tapickell <tapickell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is has been tested and works well with the cookbooks we use this with.
This is a branch that was started to skip dependencies but was put aside for a while due to priorities being shuffled, most the work was complete but the VCR tests need a major refactoring.
With the additional PR from @g3kk0 it's obvious that this needs to get into master. This branch contains some of the ideas from the other PR merged into this branch but still meeting the original spec from GE and with the updated tests passing.
The only tests failing currently are the VCR tests in
inventory_builder_spec.rband this doesn't fail locally. This is something that I have been dealing with for a while and would like to focus the effort on refactoring the tests that use vcr to either be more consistent or to utilize something else in a different branch and PR.This closes issue 14