Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (client): avoid duplicate rows when including several relations #1026

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

kevin-dp
Copy link
Contributor

@kevin-dp kevin-dp commented Mar 4, 2024

This PR fixes a bug in the DAL that caused rows to be included several times when including multiple relations.
The issue was reported on Discord: https://discord.com/channels/933657521581858818/1210387734234005614

@kevin-dp kevin-dp force-pushed the kevindp/fix-include-several branch from 5880155 to 9d5b6bc Compare March 4, 2024 11:30
Copy link
Contributor

@msfstef msfstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, looks good! I've just left a question about why we use mutation in the first place

clients/typescript/src/client/model/table.ts Show resolved Hide resolved
…inuation since the rows are mutated to add the included relations.
@kevin-dp kevin-dp merged commit c30516e into main Mar 5, 2024
7 checks passed
@kevin-dp kevin-dp deleted the kevindp/fix-include-several branch March 5, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants