Fix ordering issue in vector_orddict #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current master vector_orddict:insert function would compare all dots for
>
, rather then>=
, which will lead to a wrong ordering of vv, such as: if given#{dc1 => 1, dc2 => 1}
and#{dc1 => 1, dc=> 2}
, thevector_orddict
internal ordering would be dependent on the insert order, andvector_orddict:first
would give different results.