Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordering issue in vector_orddict #23

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

define-null
Copy link
Contributor

@define-null define-null commented Jun 15, 2022

In the current master vector_orddict:insert function would compare all dots for >, rather then >=, which will lead to a wrong ordering of vv, such as: if given
#{dc1 => 1, dc2 => 1} and #{dc1 => 1, dc=> 2}, the vector_orddict internal ordering would be dependent on the insert order, and vector_orddict:first would give different results.

@define-null
Copy link
Contributor Author

Let's wait till AntidoteDB/antidote#488 is reviewed. Maybe there are more places that should be fixed while we are on it.

@define-null define-null merged commit e7151b2 into main Jun 30, 2022
@define-null define-null deleted the defnull/fix-vector-ordict-ordering-vaxine branch June 30, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants