This repository has been archived by the owner on Mar 31, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corradio
reviewed
Nov 30, 2020
@pierresegonne Can you ping me once this is ready for review, maybe making it draft until ready? CI seems to fail. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind giving a short summary of what was changed in the footprints.yml file? It's kinda hard to diff that file 😄
Co-authored-by: Mads Nedergaard <nedergaardmads@gmail.com>
Sum up of the changes for the
|
…loom-contrib into ps/coicop_categories_for_items
Created this issue #499 to keep track of the improvements identified here that would nice to add but are not in the scope covered by this PR |
skovhus
approved these changes
Dec 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposal for resolving https://github.com/tmrowco/bloom/issues/337 by combining the two identified approaches.
Note:
Should we take that opportunity to also clean up the
footprints.yml
structure ?The top categories
Entertainment
andStores
which don't correspond to COICOP categories could for example be removed. This could enable us to have afootprints.yml
where the entries actually follow the hierarchy of the COICOP categorisation.