Skip to content
This repository has been archived by the owner on Mar 31, 2021. It is now read-only.

COICOP categories for items #488

Merged
merged 12 commits into from
Dec 18, 2020
Merged

Conversation

pierresegonne
Copy link
Member

Description

Proposal for resolving https://github.com/tmrowco/bloom/issues/337 by combining the two identified approaches.

Note:

Should we take that opportunity to also clean up the footprints.yml structure ?
The top categories Entertainment and Stores which don't correspond to COICOP categories could for example be removed. This could enable us to have a footprints.yml where the entries actually follow the hierarchy of the COICOP categorisation.

@skovhus
Copy link
Contributor

skovhus commented Dec 16, 2020

@pierresegonne Can you ping me once this is ready for review, maybe making it draft until ready? CI seems to fail. :)

@pierresegonne pierresegonne marked this pull request as draft December 16, 2020 11:25
@pierresegonne pierresegonne marked this pull request as ready for review December 16, 2020 15:05
Copy link
Member

@madsnedergaard madsnedergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind giving a short summary of what was changed in the footprints.yml file? It's kinda hard to diff that file 😄

co2eq/purchase/__tests__/footprints.test.js Outdated Show resolved Hide resolved
definitions.js Outdated Show resolved Hide resolved
co2eq/purchase/footprints.yml Show resolved Hide resolved
Co-authored-by: Mads Nedergaard <nedergaardmads@gmail.com>
@pierresegonne
Copy link
Member Author

Sum up of the changes for the footprints.yml file:

  1. Got rid of the legacy North structure where items where regrouped under non-coicop related, synthetic parents (ex: Store)
  2. moved instead all items under the COICOP category in which they belong (ex Lenovo Thinkpad X270 under Information and communication equipment)
  3. attributed them an associatedPurchaseCategory which corresponds to the key of the closest parent that is a proper COICOP category

@pierresegonne
Copy link
Member Author

Created this issue #499 to keep track of the improvements identified here that would nice to add but are not in the scope covered by this PR

@pierresegonne pierresegonne merged commit 10eff71 into master Dec 18, 2020
@pierresegonne pierresegonne deleted the ps/coicop_categories_for_items branch December 18, 2020 07:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants