Add fetch_price method in GB parsers based on fetch_price FR parser #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsnedergaard
approved these changes
Jan 27, 2022
madsnedergaard
requested changes
Jan 27, 2022
There was a problem hiding this comment.
Okay, I was a bit too fast here - there's a few chances required before we can merge this :)
- The parsers you have changed here are for Northern Ireland and the Orkney Islands. We should probably create a new file for GB only
- The
zones.jsonfile needs to be updated to use this new parser forprice
madsnedergaard
approved these changes
Jan 27, 2022
| if donnesMarche.tag != 'donneesMarche': | ||
| continue | ||
|
|
||
| start_date = arrow.get(arrow.get(donnesMarche.attrib['date']).datetime, 'Europe/London') |
There was a problem hiding this comment.
I have a doubt here if I should put 'Europe/London' or 'Europe/Paris' for the timezone.
There was a problem hiding this comment.
That is a good question 😄
Let's see how the data looks now and then we can follow-up on it if it's clear that it's off :)
Closed
pierresegonne
pushed a commit
that referenced
this pull request
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GB prices are available in the data used by the FR parser to fetch prices for FR.