Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DK-BHM parser #5888

Merged
merged 10 commits into from
Dec 19, 2023
Merged

Refactor DK-BHM parser #5888

merged 10 commits into from
Dec 19, 2023

Conversation

unitrium
Copy link
Contributor

Issue

Use the new event datastructure to refactor the new DK-BHM parser.

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier --write . and poetry run format to format my changes.

@github-actions github-actions bot added parser tests zone config Pull request or issue for zone configurations labels Sep 14, 2023
VIKTORVAV99
VIKTORVAV99 reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things.

parsers/BORNHOLM_POWERLAB.py Show resolved Hide resolved
parsers/BORNHOLM_POWERLAB.py Outdated Show resolved Hide resolved
parsers/BORNHOLM_POWERLAB.py Outdated Show resolved Hide resolved
@kruschk kruschk mentioned this pull request Oct 21, 2023
Open
96 tasks
@github-actions github-actions bot added the python Pull requests that update Python code label Dec 19, 2023
@unitrium
Copy link
Contributor Author

Got time to get back to it, ready to review again :)

VIKTORVAV99
VIKTORVAV99 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VIKTORVAV99 VIKTORVAV99 merged commit e294780 into master Dec 19, 2023
19 checks passed
@VIKTORVAV99 VIKTORVAV99 deleted the rt/refactor-dk-bhm branch December 19, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VIKTORVAV99 VIKTORVAV99 VIKTORVAV99 approved these changes

Assignees
No one assigned
Labels
parser python Pull requests that update Python code tests zone config Pull request or issue for zone configurations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unitrium @VIKTORVAV99