refactor: upgrade CA-YT with event classes #6062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 tasks
VIKTORVAV99
reviewed
Oct 31, 2023
Upgrade the parser to use the ProductionBreakdownList, ProductionMix, StorageMix, and ZoneKey classes. This should yield no functional change. Additionally: - Comply with Black's 88-column default line length limit. - Define global constants to replace magic values. - Eliminate a few unnecessary variables. Refs: electricitymaps#6011, electricitymaps#6062
Pass data to the ProductionMix object using the add_value method instead of during object instantiaton. Refs: electricitymaps#6011, electricitymaps#6062
kruschk
force-pushed
the
kruschk/6011-ca-yt
branch
from
49586f0
to
103b077
Compare
kruschk
commented
Nov 2, 2023
VIKTORVAV99
reviewed
Nov 15, 2023
github-actions
bot
added
the
zone config
VIKTORVAV99
approved these changes
Nov 21, 2023
|
I don't mind at all! Thanks for accepting this! |
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2023
* refactor: upgrade CA-YT with event classes Upgrade the parser to use the ProductionBreakdownList, ProductionMix, StorageMix, and ZoneKey classes. This should yield no functional change. Additionally: - Comply with Black's 88-column default line length limit. - Define global constants to replace magic values. - Eliminate a few unnecessary variables. Refs: #6011, #6062 * refactor: switch to ProductionMix.add_value method Pass data to the ProductionMix object using the add_value method instead of during object instantiaton. Refs: #6011, #6062 * tiny cleanup * rename CA_YT.py to YUKONENERGY.py --------- Co-authored-by: Viktor Andersson <30777521+VIKTORVAV99@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Refs: #6011, #6062
Description
Upgrade the parser to use the ProductionBreakdownList, ProductionMix, StorageMix, and ZoneKey classes. This should yield no functional change. Additionally:
Double check
poetry run test_parser "zone_key"pnpx prettier --write .andpoetry run formatto format my changes.