Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiny bit of cleanup in the parsers #6164

Merged
merged 1 commit into from
Nov 22, 2023
Merged

tiny bit of cleanup in the parsers #6164

merged 1 commit into from
Nov 22, 2023

Conversation

VIKTORVAV99
Copy link
Member

Issue

I accidentally merged 2 PR a bit too fast.

Description

This fixes the very small issues with those PRs.

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier --write . and poetry run format to format my changes.

@VIKTORVAV99 VIKTORVAV99 merged commit fda6fda into master Nov 22, 2023
17 checks passed
@VIKTORVAV99 VIKTORVAV99 deleted the vik/cleanup branch November 22, 2023 13:00
ghost pushed a commit that referenced this pull request Nov 23, 2023
@VIKTORVAV99
tiny bit of cleanup in the parsers (#6164)
574c64a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsnedergaard madsnedergaard madsnedergaard approved these changes

@tonypls tonypls Awaiting requested review from tonypls

Assignees
No one assigned
Labels
parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VIKTORVAV99 @madsnedergaard