Fix initial map state uncolored zones issue #6256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Thanks for looking into this! I'm still getting the issue on firefox, now it's happening on every refresh on firefox for me. 
|
|
I think, it should be fixed now. |
|
Just to confirm that I'm also still seeing this issue. Firefox 120.0.1 (64-bit), fresh visit to the map in a private browsing window. Happy to troubleshoot further if useful.
|
tonypls
approved these changes
Dec 20, 2023
|
Failing test is unrelated btw! |
|
Thank you @Ugzuzg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #6136
Closes #6240
Description
The main issue is that isSourceLoaded inside the effect that renders the zones is not reactive and the change of the source state doesn't trigger a re-render of the component. Subscribing to that and changing the state fixes the issue.
Adding map to a dependency list of the effects makes sure that the map reference doesn't get stale in the closure and fixes the hot reload issue on my machine.
Preview
Double check
poetry run test_parser "zone_key"pnpx prettier --write .andpoetry run formatto format my changes.