feat: refactor TH parser to use event classes #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
approved these changes
Feb 26, 2024
|
Just as a future reference, it looks like the price domain is returning 404 not found for me. But this PR does not change that so it should be addressed separately. |
96 tasks
yujia21
force-pushed
the
6011-event-class-TH
branch
from
ce74a98
to
21b7369
Compare
|
@VIKTORVAV99 It seems like MEA changed their website again - I'll fix its pricing calculation later over the weekends. I don't know if it's just me but Thailand's data in general appears to be down altogether. The original electricity generation source is still up from a quick check https://www.sothailand.com/sysgen/egat/ . |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
6011
Description
Preview
This PR updates the TH parser to use event classes as per new parser guidelines.
Instead of calling fetch_production from fetch_consumption as in the original code, I called the underlying _fetch_data directly as I felt it was cleaner and more future proof.
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.