Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 report virus Trojan:Win32/Bulta!rfn of Uninstall xxx.exe #4793

Closed
tangjfn opened this issue Mar 17, 2020 · 30 comments
Closed

Windows 10 report virus Trojan:Win32/Bulta!rfn of Uninstall xxx.exe #4793

tangjfn opened this issue Mar 17, 2020 · 30 comments

Comments

@tangjfn
Copy link

tangjfn commented Mar 17, 2020

  • Version: 22.4.1

4.2.5

  • Target: win32 x64 nsis-web

Windows 10 1909 18363.720

electron-builder execute fail, because windows has deleted the uninstall.exe

22.3.6 is OK

@baryon
Copy link

baryon commented Mar 18, 2020

I have same issue. Trojan:Win32/Bulta!rfn

@Kyusung4698
Copy link

Kyusung4698 commented Mar 19, 2020

Same Issue. My NSIS installer got blocked.

image

@Kyusung4698
Copy link

Hi, I've submitted a flagged version of my installer as false positive to Microsoft. I'll keep you updated.

@Kyusung4698
Copy link

Kyusung4698 commented Mar 20, 2020

Update: Microsoft has removed/ approved the false detection. Please see following submission:
https://www.microsoft.com/en-us/wdsi/submission/69113a4a-0fc7-423d-80ad-f6ed0cf128ad

They'll roll out a new definition file of the Windows Defender soon which will prevent this false flagging.

@adriencohen
Copy link

adriencohen commented Mar 27, 2020

I have submitted my own uninstaller too, they approved the false detection and it worked. However after rebuilding a new version of my app the uninstaller was detected again. Looks like we are going to need to pinpoint the commit which added this

Edit: It comes from version 22.4.0

@lutzroeder
Copy link
Contributor

@develar could the update to nsis 3.0.4.2 in 4e454f8 have caused this?

4e454f8b4 packages/app-builder-lib/src/targets/nsis/nsisUtil.ts      (develar             2020-03-03 13:48:34 +0100  22)   return getBinFromUrl("nsis", "3.0.4.2", "o+YZsXHp8LNihhuk7JsCDhdIgx0MKKK+1b3sGD+4zX5djZULe4/4QMcAsfQ+0r+a8FnwBt7BVBHkIkJHjKQ0sg==")

@edward-buskus
Copy link

I have same issue. Is there any solution for this problem?

@develar
Copy link
Member

develar commented Apr 1, 2020

NSIS updated to 3.0.5, maybe Windows Defender will be more happy with this version. electron-builder will be released soon.

@edward-buskus
Copy link

edward-buskus commented Apr 1, 2020

deleteAppDataOnUninstall: false helped me at the moment.

@develar develar closed this as completed Apr 1, 2020
@develar
Copy link
Member

develar commented Apr 1, 2020

Please try 22.5.0

@awlx
Copy link

awlx commented Apr 1, 2020

22.5.0 doesn't produce a build anymore:
https://ci.appveyor.com/project/awlx/jitsi-meet-electron/builds/31874856

@develar develar reopened this Apr 2, 2020
develar added a commit to develar/electron-builder that referenced this issue Apr 2, 2020
@develar
Copy link
Member

develar commented Apr 2, 2020

I don't have time today to investigate what's wrong with building on Windows using a new version of NSIS.

So, reverted to 3.0.4.1 as a quick solution.

@develar develar closed this as completed in 9c43cc3 Apr 2, 2020
BusinessDuck pushed a commit to BusinessDuck/electron-builder that referenced this issue Apr 12, 2020
gre added a commit to gre/ledger-live-desktop that referenced this issue Apr 16, 2020
gre added a commit to gre/ledger-live-desktop that referenced this issue Apr 16, 2020
@indutny-signal
Copy link
Contributor

It has been a year since initial report. Should NSIS version be reverted back to 3.0.5.0 now?

@indutny-signal
Copy link
Contributor

Friendly ping. The new NSIS build shouldn't trigger the antivirus anymore, so I think we could try bumping it up again.

@JCMais
Copy link

JCMais commented Nov 15, 2021

This seems to be happening again on the latest version.

@indutny-signal
Copy link
Contributor

I don't believe nsis version was changed since September: https://github.com/electron-userland/electron-builder/commits/master

@vnicolici
Copy link

I have a similar problem with an install.exe file coming from an Electron app: https://i.imgur.com/Cxj1weh.png

@dclipca
Copy link

dclipca commented Dec 2, 2021

@dclipca
Copy link

dclipca commented Dec 2, 2021

Updating to electron-builder 22.14.10 fixes the issue because it has NSIS 3.0.4.1.

@BarryCarlyon
Copy link

BarryCarlyon commented Jan 5, 2022

This one is rearing it's head again in the last couple of hours when trying to build.

On the uninstaller no less....

using 22.14.5 (NPM latest) on windows.

@ErikMach
Copy link

ErikMach commented Jan 6, 2022

@BarryCarlyon I had the same problem with version 22.14.5.
But I just used 22.14.12 and it worked fine.

@BarryCarlyon
Copy link

BarryCarlyon commented Jan 6, 2022

@ErikMach since 22.14.12 isn't on NPMJS I tried to intall it via github and got a weird "this is not a mac" error on my windows machine. So I'll need to dig about with that further.

@ErikMach
Copy link

ErikMach commented Jan 6, 2022

I installed it via npm with the command npm install --save-dev electron-builder@22.14.12

@BarryCarlyon
Copy link

I'll give it a poke :-D

danielgarthur added a commit to neanes/neanes that referenced this issue Feb 3, 2022
This should fix the false positive virus detection by Windows Defender

See electron-userland/electron-builder#4793
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Feb 27, 2022
Microsoft Defender considers the uninstaller virus. It's a
false-psoitive caused by `electron-builder` used to build NSIS package.

This commit solves the issue by explicitly adding `electron-builder` as
dependency. This way, `vue-cli-plugin-electron-builder` always resolves
to the desired version. Now the version used for `electron-builder` is
more controlled. New uninstaller generated by latest specified patch
does not trigger an alert, which solves the false-positive issue.

See also :
  - electron-userland/electron-builder#4793,
  - electron-userland/electron-builder#4878.
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Feb 27, 2022
Microsoft Defender considers the uninstaller virus. It's a
false-psoitive caused by `electron-builder` used to build NSIS package.

This commit solves the issue by explicitly adding `electron-builder` as
dependency. This way, `vue-cli-plugin-electron-builder` always resolves
to the desired version. Now the version used for `electron-builder` is
more controlled. New uninstaller generated by latest specified patch
does not trigger an alert, which solves the false-positive issue.

See also:
  - electron-userland/electron-builder#4793,
  - electron-userland/electron-builder#4878.
@koyuawsmbrtn
Copy link

Still an issue with the latest release of electron-builder. Issue can be reopened.

@egeres
Copy link

egeres commented Apr 14, 2022

Same issue happening here!

@augustnmonteiro
Copy link

Same here as well

@augustnmonteiro
Copy link

augustnmonteiro commented May 23, 2022

When we send and update to the users, it gets uninstalled but it doesn't get installed again.

Going to force use of 22.14.12 as for now

@augustnmonteiro
Copy link

@develar can we reopen this one?

@joehinkle11
Copy link

I have the same issue on on 23.3.3. I just started investigating it.

LarrMarburger pushed a commit to LarrMarburger/privacy.sexy that referenced this issue Nov 16, 2023
Microsoft Defender considers the uninstaller virus. It's a
false-psoitive caused by `electron-builder` used to build NSIS package.

This commit solves the issue by explicitly adding `electron-builder` as
dependency. This way, `vue-cli-plugin-electron-builder` always resolves
to the desired version. Now the version used for `electron-builder` is
more controlled. New uninstaller generated by latest specified patch
does not trigger an alert, which solves the false-positive issue.

See also:
  - electron-userland/electron-builder#4793,
  - electron-userland/electron-builder#4878.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.