Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make nsis builds (and portable builds) not run in parallel #7798

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

iffy
Copy link
Contributor

@iffy iffy commented Sep 26, 2023

This fixes #7791 by making nsis and portable builds not run in parallel.

This change should not break anyone's build process, but it could make it slower. However, I think slower is better than sometimes broken.

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

🦋 Changeset detected

Latest commit: 824aa18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 824aa18
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/652ace4711f9f200087a463a
😎 Deploy Preview https://deploy-preview-7798--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta changed the title Make nsis builds (and portable builds) not run in parallel fix: Make nsis builds (and portable builds) not run in parallel Oct 14, 2023
@mmaietta mmaietta merged commit 526e075 into electron-userland:master Oct 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spawn EBUSY failedTask=build stackTrace=Error: spawn EBUSY
2 participants