Skip to content

Commit

Permalink
fix: run nsis builds (and portable builds) sequentially (#7798)
Browse files Browse the repository at this point in the history
  • Loading branch information
iffy authored Oct 14, 2023
1 parent 2ca6212 commit 526e075
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/tough-roses-attend.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

fix: run nsis and portable builds sequentially. fixes #7791
1 change: 1 addition & 0 deletions packages/app-builder-lib/src/targets/nsis/NsisTarget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export class NsisTarget extends Target {

/** @private */
readonly archs: Map<Arch, string> = new Map()
readonly isAsyncSupported = false;

Check warning on line 45 in packages/app-builder-lib/src/targets/nsis/NsisTarget.ts

View workflow job for this annotation

GitHub Actions / test-linux (ArtifactPublisherTest,BuildTest,ExtraBuildTest,RepoSlugTest,binDownloadTest,configura...

Delete `;`

Check warning on line 45 in packages/app-builder-lib/src/targets/nsis/NsisTarget.ts

View workflow job for this annotation

GitHub Actions / test-linux (snapTest,debTest,fpmTest,protonTest)

Delete `;`

constructor(readonly packager: WinPackager, readonly outDir: string, targetName: string, protected readonly packageHelper: AppPackageHelper) {
super(targetName)
Expand Down

0 comments on commit 526e075

Please sign in to comment.