Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly setting asar to false gives a warning #698

Closed
XuluWarrior opened this issue Aug 10, 2017 · 4 comments
Closed

Explicitly setting asar to false gives a warning #698

XuluWarrior opened this issue Aug 10, 2017 · 4 comments
Labels
question ❓ Question about using Electron Packager. Not supported in this issue tracker.

Comments

@XuluWarrior
Copy link

  • [ x ] I have read the contribution documentation for this project.
  • [ x ] I agree to follow the code of conduct that this project follows, as appropriate.
  • [ x ] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
Adding --asar=false to the command line gives the warning
WARNING: asar parameter set to an invalid value (false), ignoring and disabling asar

I realise that false is the default value but sometimes it aids clarity to set parameters explicitly.

@malept malept added the question ❓ Question about using Electron Packager. Not supported in this issue tracker. label Aug 10, 2017
@malept
Copy link
Member

malept commented Aug 10, 2017

Due to how minimist works (the command line argument parser we use), you need to specify --no-asar instead of --asar=false (which makes it think the value of the argument is the string "false").

@malept malept closed this as completed Aug 10, 2017
@XuluWarrior
Copy link
Author

Is the option --no-asar or your use of minimist syntax documented anywhere? I can't find it in usage.txt or api.md

In fact api.md states

asar

Boolean or Object (default: false)

@malept
Copy link
Member

malept commented Aug 10, 2017

Well, there's --no-prune. There's an issue in minimist about documenting --no-.

The API docs are written with the JS API in mind.

@malept
Copy link
Member

malept commented Aug 10, 2017

[...] sometimes it aids clarity to set parameters explicitly.

I would suggest instead of using the CLI, instead use the JavaScript API and enumerate all of the Packager options in a build.js file. Otherwise, you're going to hit "command too long" problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question ❓ Question about using Electron Packager. Not supported in this issue tracker.
Projects
None yet
Development

No branches or pull requests

2 participants