feat: support electron v15 #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
reviewed
Jan 10, 2022
There was a problem hiding this comment.
Thanks so much, @xupea, this looks great! Apologies for the delay, we went into a quiet period in December, and I'm just catching up on PRs.
It looks like there are just two things we need to do before this passes CI:
- Could you please run
npm run prettier:writeto clean up some lint issues? That should be pretty quick - I think there are some TypeScript errors coming from WebDriverIO - knocking webdriver back down to
^6.9.1seemed to resolve these for me in the short-term. You can runnpm run testto see those.
If you'd like, happy to push these fixes up to your branch and get this merged for you 🙂
Thank you again so much for the fixes! It's very appreciated!
|
@VerteDinde lint and ts issues are all fixed, please review. |
|
Going to force merge this and reconcile the Ubuntu tests in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@VerteDinde please review