-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support full Electron API #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this library started, I was adding helper commands as I needed them to assert specific things for the tests I was trying to write.
This worked fine but isn't really a sustainable way to build this library going forward. To get 100% Electron API coverage via this approach would be tedious and it would be falling behind as the APIs were updated.
This pull request introduces support for the entire Electron API by dynamically generating it when the app is started. This is exposed through 5 new top-level properties:
browserWindow
which is an alias torequire('electron').remote.getCurrentWindow()
webContents
which is an alias torequire('electron').remote.getCurrentWebContents()
electron
which is an alias torequire('electron')
mainProcess
which is an alias torequire('electron').remote.process
rendererProcess
which is an alias toglobal.process
in the browser windowBefore
After
This pull request will remove the old helper breaking backwards compatibility and so the major will be bumped in the next release after this is merged.
Remaining Tasks
/cc @zeke