Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add switchWindow command #365

Merged
merged 4 commits into from
Aug 7, 2019
Merged

feat: add switchWindow command #365

merged 4 commits into from
Aug 7, 2019

Conversation

magne4000
Copy link
Contributor

This PR adds a switchWindow command as documented in recent versions of WebdriverIO

@codebytere
Copy link
Member

@magne4000 some conflicts here: could you please rebase and then i can give this a review?

@magne4000
Copy link
Contributor Author

@codebytere here you go 👍

@codebytere codebytere changed the title add switchWindow command feat: add switchWindow command Aug 6, 2019
codebytere
codebytere reviewed Aug 6, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively small comment & overall looking good! This new command should also be added to the main README.

Once that's addressed we can get this merged

lib/application.js Outdated Show resolved Hide resolved
@magne4000
Copy link
Contributor Author

@codebytere Everything should be OK now 👍

codebytere
codebytere approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Looks great 🚀

@codebytere codebytere merged commit 404b5ab into electron-userland:master Aug 7, 2019
@magne4000 magne4000 deleted the add-switch-window-command branch August 9, 2019 09:40
@ChrisHSandN ChrisHSandN mentioned this pull request May 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magne4000 @codebytere