Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can use
build.rollupOptions.external
to externalize built in modules & electron.the
node_modules/.vite-plugin-electron-renderer/fs.js
glue code work when dev (esbuild).but can cause problem when build (rollup)
like fs-extra > graceful-fs package, without rollup external
will cause error
because
node_modules/.vite-plugin-electron-renderer/fs.js
esmodulevar require$$0$7 = /* @__PURE__ */ getAugmentedNamespace(fs$o);
getAugmentedNamespace
define a getterclose
onfs
graceful-fs
try to overwritefs.close
, cause the error present by the imagethe error can be prevented by set
{ requireReturnsDefault: 'prefer' / 'auto' }
options of@rollup/plugin-commonjs
to get rid ofObject.defineProperty
but it's better to external these modules.
AND background:
magicdawn/magicdawn#132 (comment)