This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
test: add typescript-eslint/recommended-requiring-type-checking #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, disable most of its warnings because there are quite a few. They can be re-enabled piecemeal.
This reverts commit a4cbed9.
ckerr
deleted the
test/typescript-eslint-recommended-requiring-type-checking
branch
This was referenced Jul 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in yesterday's standup. Adds typescript-eslint/recommended-requiring-type-checking.
Note: I've disabled several of that plugin's tests because they'll take more work to fix. We should still do that work! But by disabling some for now, we can get the benefit of the rest of the tests without blocking on fixing everything.
This PR also removes a lot of the individual checks that are not in the recommended lists. This change is arguably (a) incidental to the above topic and (b) opinionated, so I'm happy to revert that change there's disagreement on this. My thinking is that I just copied it from another project when this repo was first getting started, so I don't believe there's been much thought put into what's in that list.