Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci status check logic #506

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix: ci status check logic #506

merged 1 commit into from
Aug 9, 2023

Conversation

codebytere
Copy link
Member

Fixes and cleans up our CI status check logic. It's been broken since we moved to unified AppVeyor on fork and non-fork PRs.

`main`

electron on git:main ❯ e ci status                                 3:40PM
Electron CI Status
  Ref: main

  Circle CI
  ⦿ macOS - running - 56aa347f-03bb-4f3d-a2d5-da28a1d0389c

  ⦿ Linux - running - a7af7126-8397-4b0d-92c3-7cc6d75aa1e4

  ⦿ Lint - success - 120686f1-5a4e-4a35-8781-caedb852586d


  Appveyor
  ⦿ Windows ia32 - running - 47752802

  ⦿ Windows x64 - running - 47752803

  ⦿ Windows Arm - running - 47752801

PR #39428

electron on git:main ❯ e ci status --ref 39428                     3:49PM
Electron CI Status
  Ref: refs/pull/39428/head

  Circle CI
  ⦿ macOS - success - a32a0365-a603-4549-ad14-193183dc661e

  ⦿ Linux - success - 47351e9f-7c1f-4fd0-af96-05eb839894aa

  ⦿ Lint - success - 48f75d6c-0aaa-43ad-8b9f-9b7fdff80bf2


  Appveyor
  ⦿ Windows x64 - success - 47750687

  ⦿ Windows ia32 - success - 47750688

  ⦿ Windows Arm - success - 47750686

Fork PR #39380

electron on git:main ❯ e ci status --ref 39380                     3:54PM
Electron CI Status
  Ref: refs/pull/39380/head

  Circle CI
  ⦿ macOS - Missing
  ⦿ Linux - Missing
  ⦿ Lint - success - b69abafa-0140-42b2-82b3-0f6307e48317

  ⦿ docs-only - success - 65b87d94-ff86-40ff-9037-2253fd377b7e


  Appveyor
  ⦿ Windows x64 - success - 47744343

  ⦿ Windows ia32 - success - 47744344

  ⦿ Windows Arm - success - 47744352

@codebytere codebytere requested review from ckerr and a team as code owners August 9, 2023 13:58
@jkleinsc jkleinsc merged commit 9da8198 into main Aug 9, 2023
8 checks passed
@jkleinsc jkleinsc deleted the fixup-ci-checks branch August 9, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants