Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set no notes in Dependabot PRs #110

Merged
merged 1 commit into from
May 8, 2024
Merged

feat: set no notes in Dependabot PRs #110

merged 1 commit into from
May 8, 2024

Conversation

dsanders11
Copy link
Member

Save the humans the effort of editing Dependabot PR bodies.

@dsanders11 dsanders11 marked this pull request as ready for review May 8, 2024 06:14
@dsanders11 dsanders11 requested a review from a team May 8, 2024 06:16
MarshallOfSound
MarshallOfSound reviewed May 8, 2024
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to check it doesn't already have a notes section, to avoid Notes: none being repeated

@dsanders11
Copy link
Member Author

Should be covered by the if (!releaseNotes) { block it's inside of, unless I misread the code.

@dsanders11 dsanders11 merged commit baaaa6b into main May 8, 2024
3 checks passed
@dsanders11 dsanders11 deleted the feat/dependabot-no-notes branch May 8, 2024 20:43
@dsanders11 dsanders11 mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dsanders11 @ckerr @codebytere @MarshallOfSound