Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholders in the paths #137

Closed
artemave opened this issue Jan 4, 2017 · 5 comments
Closed

Placeholders in the paths #137

artemave opened this issue Jan 4, 2017 · 5 comments
Labels

Comments

@artemave
Copy link

artemave commented Jan 4, 2017

Hello,

Latest version (1.5.5) stores build artifacts in the directories with placeholders in names. Then electron runtime can't find them and nothing works.

image

image

I am on node 6.7, running electron-rebuild from a script with the following params:

image

@MarshallOfSound
Copy link
Member

@artemave I'll look into this when I get a chance, it looks like some weird prebuilt issue 😕

MarshallOfSound added a commit that referenced this issue Jan 5, 2017
* Replaces the standard node-gyp bindings template strings

Fixes #137
@MarshallOfSound
Copy link
Member

@artemave PR is up to handle this 👍

@artemave
Copy link
Author

Merge?

@antonycourtney
Copy link

Hit this same issue myself today, also when trying to run electron-rebuild on sqlite3. Spent an hour or so digging in enough to understand the cause and was just about to file my own bug report when I discovered this issue. As far as I can tell node-sqlite3 can not be built for electron using electron-rebuild until this issue is resolved.

As an interim workaround: I can confirm that reverting electron-rebuild to 1.4.0 will work with the latest electron (1.4.14). (I've only tested with electron-1.4.7. and 1.4.14, but I'd expect everything in between to work too).

@hl-a-k
Copy link

hl-a-k commented Jan 18, 2017

I have the same problem.
I have rename {node_abi}-{platform}-{arch} to electron-v1.4-darwin-x64 ,it work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants