navigator.languages returns an empty array

[kysely]

• Electron version: 1.7.9
• Operating system: macOS

Expected behavior

navigator.languages should return array of user's preferred languages, e.g. ["en-US", "zh-CN", "ja-JP"]

Actual behavior

navigator.languages returns an empty array []

How to reproduce

Create a primitive HTML file that logs navigator.languages into console. Then try loading via file://, http and inside Electron's renderer process. The first two will give you actual results while renderer yields empty array.

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

[kysely]

Okay, so you can set the navigator.languages to your own custom value in preload, but this is still just a workaround.

To obtain actual user locale settings during preload, use os-locale module. Make sure sandbox is disabled on the window.

Object.defineProperty(navigator, 'languages', {
    value: ["en-US", "zh-CN", "ja-JP"],
    configurable: true
});

[felixrieseberg]

Yep, that's a legit bug (or at least a documentation issue).

[melvin-clickprofits]

Hi i'm kinda stuck on this issue, i have implemented skype https://dev.skype.com/webcontrol on web page, but i got an error on their js library due to a bad checking of the navigator.languages

is there any work around to set default value for navigator.languages ?

main issue is the skype sdk loaded by an iframe injected by the sdk, so even i set it in my page, it will no work.

Thanks in advance.

[kysely]

@melvin-clickprofits Did you try the solution I propose above? It works for me.

If you need to set navigator.languages for the iframed document, you can do it the same way, only instead navigator object, you'd need to pass the iframe document's navigator, like this:

Object.defineProperty(document.querySelector("#iframeId").contentWindow.navigator, 'languages', {
    value: ["en-US", "zh-CN", "ja-JP"], // or whatever you want
    configurable: true
});

And of course, you'd need to set the iframe navigator on its parent page, not during BrowserWindow preload.

[melvin-clickprofits]

@kysely tested it works, ju Thanks 👍, just have to make sure the iframe is already inserted

[haoRchen]

Hi, I'd love to tackle this if no one is working on it.

[nitsakh]

I'm working on it currently.

[tonyganch]

@ckerr, can this issue be closed? I see PR merged.

[nornagon]

Looks fixed to me!